Issue 10470043: code review 10470043: cmd/gc: fix pointer composite literals in exported if s...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10470043: code review 10470043: cmd/gc: fix pointer composite literals in exported if s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by remyoudompheng

Modified:
10 years, 9 months ago

Reviewers:
r, DMorsing, dfc, iant

CC:
rsc, golang-dev, r

Visibility:
Public.

Description

cmd/gc: fix pointer composite literals in exported if statements. Fixes issue 4230 (again).

Patch Set 1 #

Patch Set 2 : diff -r 56909cb770fe https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 56909cb770fe https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 56909cb770fe https://go.googlecode.com/hg/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	src/cmd/gc/fmt.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug465.dir/a.go	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	test/fixedbugs/bug465.dir/b.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 10 months ago (2013-06-23 16:30:51 UTC) #1

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=d04e6b0bcacf *** cmd/gc: fix pointer composite literals in exported if statements. Fixes ...

10 years, 10 months ago (2013-06-23 16:39:29 UTC) #3

iant

Would this be appropriate for a 1.1.2 release if there is one?

10 years, 10 months ago (2013-06-24 05:07:18 UTC) #4

DMorsing

There is a workaround for this issue, but the change is so minor that I'd ...

10 years, 10 months ago (2013-06-24 06:15:07 UTC) #5

dfc

10 years, 9 months ago (2013-07-02 01:02:04 UTC) #7

I'd say leave it out of 1.1.x. At this point 1.1.2 will only have two
fixes for compiler bugs, I think it is safer to not include this fix.

On Tue, Jul 2, 2013 at 10:59 AM, Russ Cox <rsc@golang.org> wrote:
> Let's leave this one out.
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Expand All Messages | Collapse All Messages