code review 104690043: make.bat: return exit code to dashboard builder

make.bat: return exit code to dashboard builder

Fixes issue 7806.

[brainman, 2014-07-11 03:53:21]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux, 2014-07-11 15:53:33]

LGTM.

[brainman, 2014-07-12 05:18:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=67f9ef140028 ***

make.bat: return exit code to dashboard builder

Fixes issue 7806.

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://codereview.appspot.com/104690043

[gobot, 2014-07-12 05:30:51]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/2756a7264b93dd6d5acbbe65ab6cb97ed8fe7631

[dave_cheney.net, 2014-07-12 05:32:43]

False.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestFinalizerType-4 (6.84s)
mfinal_test.go:61: finalizer for type func(*int) didn't run
FAIL
FAIL runtime 195.665s
Build complete, duration 11m43.71612903s. Result: error: exit status 1

On Sat, Jul 12, 2014 at 3:30 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/2756a7264b93dd6d5acbbe65ab6cb97ed8fe7631
>
>
> https://codereview.appspot.com/104690043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[brainman, 2014-07-17 07:34:43]

It appears windows-amd64-race builder is broken since that change. The builder
says ok, but it is false - I saw it said "ok" very quickly after I have
submitted a CL (it could not run all tests that quickly). All subrepos are also
broken.

Alex

[minux, 2014-07-17 17:55:26]

+Dmitry

On Thu, Jul 17, 2014 at 3:34 AM, <alex.brainman@gmail.com> wrote:

> It appears windows-amd64-race builder is broken since that change. The
> builder says ok, but it is false - I saw it said "ok" very quickly after
> I have submitted a CL (it could not run all tests that quickly). All
> subrepos are also broken.
>
Right. It seems the race builder has some custom settings that are
incompatible
with the change.

[brainman, 2014-07-18 00:55:54]

On 2014/07/17 17:55:26, minux wrote:
> >
> Right. It seems the race builder has some custom settings that are
> incompatible
> with the change.

I didn't investigate this properly, I am not sure about that. How do you know
that "the race builder has some custom settings"? What are they?

I will investigate this, but not sure when. Should I revert this change for now?

Alex

[minux, 2014-07-18 06:44:10]

On Thu, Jul 17, 2014 at 8:55 PM, <alex.brainman@gmail.com> wrote:

> On 2014/07/17 17:55:26, minux wrote:
>
>> >
>> Right. It seems the race builder has some custom settings that are
>> incompatible
>> with the change.
>>
>
> I didn't investigate this properly, I am not sure about that. How do you
> know that "the race builder has some custom settings"? What are they?
>
> I will investigate this, but not sure when. Should I revert this change
> for now?
>
Have you tried to run race.bat on windows/amd64 host to see what happens?
I believe the change is correct and shouldn't affect race.bat, so I'd like
to know
why before rollback.

Dmitry, is windows-amd64-race builder just running race.bat or is it using
some
custom batch script?

[brainman, 2014-07-18 07:01:57]

On 2014/07/18 06:44:10, minux wrote:
> >
> Have you tried to run race.bat on windows/amd64 host to see what happens?

I thought I did test ait properly, but obviously not. I will test some more.

> I believe the change is correct and shouldn't affect race.bat, so I'd like
> to know
> why before rollback.

Lets leave it for now - we have enough working builders for now. I will try to
understand why it could fail.

Alex

[dvyukov, 2014-07-18 09:28:40]

On Fri, Jul 18, 2014 at 10:43 AM, minux <minux@golang.org> wrote:
>
> On Thu, Jul 17, 2014 at 8:55 PM, <alex.brainman@gmail.com> wrote:
>>
>> On 2014/07/17 17:55:26, minux wrote:
>>>
>>> >
>>> Right. It seems the race builder has some custom settings that are
>>> incompatible
>>> with the change.
>>
>>
>> I didn't investigate this properly, I am not sure about that. How do you
>> know that "the race builder has some custom settings"? What are they?
>>
>> I will investigate this, but not sure when. Should I revert this change
>> for now?
>
> Have you tried to run race.bat on windows/amd64 host to see what happens?
> I believe the change is correct and shouldn't affect race.bat, so I'd like
> to know
> why before rollback.
>
> Dmitry, is windows-amd64-race builder just running race.bat or is it using
> some
> custom batch script?


Yes, there was a custom script because race.bat was not working before
this change.
I've removed it, let's see what happens.

[minux, 2014-07-18 18:47:45]

On Fri, Jul 18, 2014 at 5:28 AM, Dmitry Vyukov <dvyukov@google.com> wrote:

> On Fri, Jul 18, 2014 at 10:43 AM, minux <minux@golang.org> wrote:
> > On Thu, Jul 17, 2014 at 8:55 PM, <alex.brainman@gmail.com> wrote:
>
>> On 2014/07/17 17:55:26, minux wrote:
> >>> Right. It seems the race builder has some custom settings that are
> >>> incompatible
> >>> with the change.
> >> I didn't investigate this properly, I am not sure about that. How do you
> >> know that "the race builder has some custom settings"? What are they?
> >>
> >> I will investigate this, but not sure when. Should I revert this change
> >> for now?
> >
> > Have you tried to run race.bat on windows/amd64 host to see what happens?
> > I believe the change is correct and shouldn't affect race.bat, so I'd
> like
> > to know
> > why before rollback.
> >
> > Dmitry, is windows-amd64-race builder just running race.bat or is it
> using
> > some
> > custom batch script?
>
> Yes, there was a custom script because race.bat was not working before
> this change.
> I've removed it, let's see what happens.
>
The builder still seems to be broken, but I don't understand how could that
happen.

[brainman, 2014-07-21 01:04:52]

Yes, I have made mistake. Here https://codereview.appspot.com/118020043/ is a
fix.

Alex