Issue 10459044: code review 10459044: go.tools/go/types: handle p.x with p of type P *S

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10459044: code review 10459044: go.tools/go/types: handle p.x with p of type P *S (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by gri

Modified:
11 years, 9 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types: handle p.x with p of type P *S

Patch Set 2 : diff -r c23bf80f7c2f https://code.google.com/p/go.tools #

Patch Set 3 : diff -r c23bf80f7c2f https://code.google.com/p/go.tools #

Total comments: 4

Patch Set 4 : diff -r c23bf80f7c2f https://code.google.com/p/go.tools #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -0 lines)			Patch
	M	go/types/lookup.go	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
	M	go/types/testdata/decls3.src	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 9 months ago (2013-06-22 04:01:20 UTC) #1

adonovan

LGTM https://codereview.appspot.com/10459044/diff/4003/go/types/lookup.go File go/types/lookup.go (right): https://codereview.appspot.com/10459044/diff/4003/go/types/lookup.go#newcode42 go/types/lookup.go:42: // providing LookupField and LookupMethod as well. My ...

11 years, 9 months ago (2013-06-24 14:21:01 UTC) #2

gri

https://codereview.appspot.com/10459044/diff/4003/go/types/lookup.go File go/types/lookup.go (right): https://codereview.appspot.com/10459044/diff/4003/go/types/lookup.go#newcode42 go/types/lookup.go:42: // providing LookupField and LookupMethod as well. On 2013/06/24 ...

11 years, 9 months ago (2013-06-24 16:54:25 UTC) #3

gri

11 years, 9 months ago (2013-06-24 16:58:30 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=dfc8026e3dfa&repo=tools ***

go.tools/go/types: handle p.x with p of type P *S

R=adonovan
CC=golang-dev
https://codereview.appspot.com/10459044

Expand All Messages | Collapse All Messages