code review 10454043: all: fix some failed goroutines cause tests deadlock bug

all: fix some failed goroutines cause tests deadlock bug

If other goroutines test failed, assure call wg.Done t.Fatalf,
and use t.Errorf instead t.Fatalf.

Fixes issue 5746.

[chai2010, 2013-06-21 09:21:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://code.google.com/p/go

[bradfitz, 2013-06-21 20:34:12]

Changing to using defer for wg.Done(), is fine, but I don't see the reason to
change t.Fatalf to t.Errorf.

Could you update this to just do the defer?

[chai2010, 2013-06-22 13:23:58]

On 2013/06/21 20:34:12, bradfitz wrote:
> Changing to using defer for wg.Done(), is fine, but I don't see the reason to
> change t.Fatalf to t.Errorf.
> 
> Could you update this to just do the defer?

I also think the t.Fatalf is better.

But the document said: t.FailNow must be called from the goroutine running the
test or benchmark function [1].

And some gophers suggest use t.Errof too(in the issue comments [2]).

---

[1]
http://golang.org/pkg/testing/#T.FailNow

[2]
https://code.google.com/p/go/issues/detail?id=5746

[chai2010, 2013-07-17 01:33:05]

On 2013/06/22 13:23:58, chai2010 wrote:
> On 2013/06/21 20:34:12, bradfitz wrote:
> > Changing to using defer for wg.Done(), is fine, but I don't see the reason
to
> > change t.Fatalf to t.Errorf.
> > 
> > Could you update this to just do the defer?
> 
> I also think the t.Fatalf is better.
> 
> But the document said: t.FailNow must be called from the goroutine running the
> test or benchmark function [1].
> 
> And some gophers suggest use t.Errof too(in the issue comments [2]).
> 
> ---
> 
> [1]
> http://golang.org/pkg/testing/#T.FailNow
> 
> [2]
> https://code.google.com/p/go/issues/detail?id=5746

ping

[dfc, 2013-07-17 09:11:42]

I'm having a hard time getting excited about this change. While these tests
don't display the best form, they aren't broken and that makes me inclined to
not change them at this time.

[r, 2013-07-18 10:23:34]

No, thanks.

[gobot, 2013-12-20 02:54:51]

R=bradfitz@golang.org (assigned by chaishushan@gmail.com)