code review 104320043: RFC: fmt: measure width in runes not bytes with %c and ...

fmt: measure width in runes not bytes with %c and %q for ints

Change these calls to measure width in runes not bytes:
fmt.Printf("(%5q)\n", '§')
fmt.Printf("(%3c)\n", '§')

 Fixes issue 8275.

[mb, 2014-07-29 18:13:04]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[mb, 2014-07-29 18:30:18]

Patch Set 3 is a solution that converts the runes to strings.
Rob pointed out in golang-dev@ that converting to strings likely adds
allocations.
This explains my initial surprise at seeing explicit byte counting in the fmt
package (and thinking I'm misunderstanding what the code does) because the
documentation talks about rune counting.

The latest patch is a surprisingly short 1-line fix. It passes all tests but if
someone familiar with the fmt package has a better approach to this bug feel
free to use my tests, make a new CL and we can close this one.

[r, 2014-07-29 20:34:29]

LGTM

i submitted before fixing the CL description to drop the RFC. i was distracted
by hg issues. mea culpa.

[mb, 2014-07-29 20:56:29]

I updated the CL description. Looks like another commit was made instead, which
lists me twice in the A+C files:
https://code.google.com/p/go/source/detail?r=27e6707fe68da8d217ba2f2290f825fb...
Perhaps a bug in the tool that generates those files?

[r, 2014-07-29 22:38:42]

https://codereview.appspot.com/118420043 sent

My fault. Tools let me down but it was my mistake.

-rob

[r, 2014-07-29 23:46:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=83651ae3a9b9 ***

fmt: measure width in runes not bytes with %c and %q for ints

This is meant to share my progress on Issue 8275, if it's useful to you. I'm not
familiar with the formatter's internals, so this change is likely naive.

Change these calls to measure width in runes not bytes:
fmt.Printf("(%5q)\n", '§')
fmt.Printf("(%3c)\n", '§')

 Fixes issue 8275.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/104320043

Committer: Rob Pike <r@golang.org>

[gobot, 2014-07-30 00:01:47]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/f400df3e9c7504acffe219354181f4b8c1e3d492