Issue 104290043: code review 104290043: syscall: add source-specific multicast socket options f...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104290043: code review 104290043: syscall: add source-specific multicast socket options f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by mikio

Modified:
9 years, 9 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

syscall: add source-specific multicast socket options for FreeBSD Update issue 8266

Patch Set 1 : diff -r 36ffbae640bd https://code.google.com/p/go #

Patch Set 2 : diff -r d371eab5a39e https://code.google.com/p/go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -7 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_freebsd.go	View	1 chunk	+28 lines, -6 lines	0 comments	Download
M	src/pkg/syscall/types_freebsd.go	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_freebsd_386.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_freebsd_amd64.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_freebsd_arm.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_386.go	View	3 chunks	+22 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_amd64.go	View	3 chunks	+24 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_arm.go	View	3 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 10 months ago (2014-06-23 09:27:50 UTC) #1

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=1d13818e6b3d *** syscall: add source-specific multicast socket options for FreeBSD Update issue ...

9 years, 10 months ago (2014-06-23 22:03:54 UTC) #3

gobot

9 years, 10 months ago (2014-06-23 22:12:35 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/8e9009d1d42e36dfa3a131dc01fa50d242b08070

Expand All Messages | Collapse All Messages