Issue 10420043: code review 10420043: cmd/go: another attempt at flag handling for coverage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10420043: code review 10420043: cmd/go: another attempt at flag handling for coverage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by r

Modified:
11 years, 9 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/go: another attempt at flag handling for coverage The -cover flag is now just enable/disable and is implied if either of the other flags is set.

Patch Set 1 #

Patch Set 2 : diff -r 4298a713c372 https://code.google.com/p/go #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -36 lines)			Patch
M	src/cmd/go/doc.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/cmd/go/test.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/cmd/go/testflag.go	View	5 chunks	+18 lines, -28 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 9 months ago (2013-06-19 16:30:07 UTC) #1

11 years, 9 months ago (2013-06-19 16:44:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7e6f9b9091c4 ***

cmd/go: another attempt at flag handling for coverage
The -cover flag is now just enable/disable and is implied if
either of the other flags is set.

R=rsc
CC=golang-dev
https://codereview.appspot.com/10420043

Expand All Messages | Collapse All Messages