Issue 10401050: code review 10401050: compress/bzip2: don't panic on invalid input.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10401050: code review 10401050: compress/bzip2: don't panic on invalid input. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by agl1

Modified:
10 years, 11 months ago

Reviewers:
r, bradfitz

CC:
golang-dev, r, bradfitz

Visibility:
Public.

Description

compress/bzip2: don't panic on invalid input. Fixes 5747.

Patch Set 1 #

Patch Set 2 : diff -r 0a6504fd5a7a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0a6504fd5a7a https://code.google.com/p/go/ #

Patch Set 4 : diff -r af0c031528c3 https://code.google.com/p/go/ #

Patch Set 5 : diff -r af0c031528c3 https://code.google.com/p/go/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -0 lines)			Patch
	M	src/pkg/compress/bzip2/bzip2.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
	M	src/pkg/compress/bzip2/bzip2_test.go	View	1 2 3 4	2 chunks	+164 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 11 months ago (2013-06-21 21:07:15 UTC) #1

bradfitz

LGTM but maybe add test from http://play.golang.org/p/WI-rKRU4Ld ? On Fri, Jun 21, 2013 at 2:16 ...

10 years, 11 months ago (2013-06-21 21:22:56 UTC) #3

agl1

On Fri, Jun 21, 2013 at 5:22 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > LGTM but ...

10 years, 11 months ago (2013-06-24 14:58:46 UTC) #4

agl1

10 years, 11 months ago (2013-06-24 14:59:49 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=13e16bc02f6d ***

compress/bzip2: don't panic on invalid input.

Fixes 5747.

R=golang-dev, r, bradfitz
CC=golang-dev
https://codereview.appspot.com/10401050

Expand All Messages | Collapse All Messages