Issue 103900046: code review 103900046: [release-branch.go1.3] cmd/cgo: for typedef of untagged...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103900046: code review 103900046: [release-branch.go1.3] cmd/cgo: for typedef of untagged... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by rsc

Modified:
9 years, 10 months ago

Reviewers:
iant

CC:
golang-codereviews, iant, r

Visibility:
Public.

Description

[release-branch.go1.3] cmd/cgo: for typedef of untagged struct, use typedef name in C code ««« CL 103080043 / 5e058e21b67d cmd/cgo: for typedef of untagged struct, use typedef name in C code Fixes issue 8148. LGTM=cookieo9, rsc R=rsc, cookieo9 CC=golang-codereviews https://codereview.appspot.com/103080043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 805f31113fe8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 805f31113fe8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 805f31113fe8 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 055bfb8a7a57 https://code.google.com/p/go/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	A	misc/cgo/test/issue8148.go	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
	M	src/cmd/cgo/gcc.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 10 months ago (2014-06-06 20:53:22 UTC) #1

rsc

9 years, 10 months ago (2014-06-07 02:06:55 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=964b3798876c ***

[release-branch.go1.3] cmd/cgo: for typedef of untagged struct, use typedef name
in C code

««« CL 103080043 / 5e058e21b67d
cmd/cgo: for typedef of untagged struct, use typedef name in C code

Fixes issue 8148.

LGTM=cookieo9, rsc
R=rsc, cookieo9
CC=golang-codereviews
https://codereview.appspot.com/103080043
»»»

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://codereview.appspot.com/103900046

Expand All Messages | Collapse All Messages