Issue 10386043: code review 10386043: cmd/cgo: avoid leaking fds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10386043: code review 10386043: cmd/cgo: avoid leaking fds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by dave

Modified:
10 years, 10 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/cgo: avoid leaking fds Fixes issue 5714.

Patch Set 1 #

Patch Set 2 : diff -r f5f5eb2a5b8b https://code.google.com/p/go #

Patch Set 3 : diff -r f5f5eb2a5b8b https://code.google.com/p/go #

Patch Set 4 : diff -r 27baf5978be6 https://code.google.com/p/go #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/cmd/cgo/gcc.go	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 10 months ago (2013-06-18 12:19:01 UTC) #1

dave_cheney.net

10 years, 10 months ago (2013-06-18 13:20:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0581827a7481 ***

cmd/cgo: avoid leaking fds

Fixes issue 5714.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/10386043

Expand All Messages | Collapse All Messages