Issue 10373043: code review 10373043: go-tour: do not clear environment when running programs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10373043: code review 10373043: go-tour: do not clear environment when running programs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by brainman

Modified:
10 years, 11 months ago

Reviewers:
adg

CC:
adg, golang-dev

Visibility:
Public.

Description

go-tour: do not clear environment when running programs Fixes issue 5694

Patch Set 2 : diff -r 372af84498ad https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 372af84498ad https://code.google.com/p/go-tour #

Total comments: 4

Patch Set 4 : diff -r 372af84498ad https://code.google.com/p/go-tour #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	gotour/local.go	View	1 2 3	1 chunk	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 11 months ago (2013-06-18 06:01:43 UTC) #1

adg

Thank you for picking this up. https://codereview.appspot.com/10373043/diff/5001/gotour/local.go File gotour/local.go (right): https://codereview.appspot.com/10373043/diff/5001/gotour/local.go#newcode162 gotour/local.go:162: // environ returns ...

10 years, 11 months ago (2013-06-18 07:12:35 UTC) #2

brainman

Hello adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 11 months ago (2013-06-18 07:40:42 UTC) #3

brainman

https://codereview.appspot.com/10373043/diff/5001/gotour/local.go File gotour/local.go (right): https://codereview.appspot.com/10373043/diff/5001/gotour/local.go#newcode162 gotour/local.go:162: // environ returns original execution environment with GOPATH On ...

10 years, 11 months ago (2013-06-18 07:40:47 UTC) #4

adg

10 years, 11 months ago (2013-06-18 08:14:23 UTC) #6

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=63620f922bb2
***

go-tour: do not clear environment when running programs

Fixes Go issue 5694

R=adg
CC=golang-dev
https://codereview.appspot.com/10373043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages