code review 10370043: net/rpc: fix RegisterName rejects "." character.

net/rpc: fix RegisterName rejects "." character.

Fixes issue 5617.

[chai2010, 2013-06-18 03:19:05]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
http://code.google.com/p/go

[bradfitz, 2013-06-18 04:40:14]

R=r

[gobot, 2013-06-18 17:36:06]

R=r (assigned by r)

[rsc, 2013-06-21 17:40:19]

https://codereview.appspot.com/10370043/diff/5001/src/pkg/net/rpc/server.go
File src/pkg/net/rpc/server.go (right):

https://codereview.appspot.com/10370043/diff/5001/src/pkg/net/rpc/server.go#n...
src/pkg/net/rpc/server.go:563: periodIndex :=
strings.LastIndex(req.ServiceMethod, ".")
s/periodIndex/dot/

https://codereview.appspot.com/10370043/diff/5001/src/pkg/net/rpc/server.go#n...
src/pkg/net/rpc/server.go:568: serviceMethod := []string{
Thanks for preserving the previous behavior, but making a slice here just to use
[0] and [1] below is probably overkill.

serviceName := req.ServiceMethod[:dot]
methodName := req.ServiceMethod[dot+1:]

and then below s/serviceMethod[0]/serviceName/ and
s/serviceMethod[1]/methodName/.

[chai2010, 2013-06-22 14:23:30]

https://codereview.appspot.com/10370043/diff/5001/src/pkg/net/rpc/server.go
File src/pkg/net/rpc/server.go (right):

https://codereview.appspot.com/10370043/diff/5001/src/pkg/net/rpc/server.go#n...
src/pkg/net/rpc/server.go:563: periodIndex :=
strings.LastIndex(req.ServiceMethod, ".")
On 2013/06/21 17:40:20, rsc wrote:
> s/periodIndex/dot/

Done.

https://codereview.appspot.com/10370043/diff/5001/src/pkg/net/rpc/server.go#n...
src/pkg/net/rpc/server.go:568: serviceMethod := []string{
On 2013/06/21 17:40:20, rsc wrote:
> Thanks for preserving the previous behavior, but making a slice here just to
use
> [0] and [1] below is probably overkill.
> 
> serviceName := req.ServiceMethod[:dot]
> methodName := req.ServiceMethod[dot+1:]
> 
> and then below s/serviceMethod[0]/serviceName/ and
> s/serviceMethod[1]/methodName/.

Done.

[r, 2013-06-24 20:22:44]

LGTM

[r, 2013-06-24 20:23:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=33c84d77a5a4 ***

net/rpc: fix RegisterName rejects "." character.

Fixes issue 5617.

R=r, rsc
CC=gobot, golang-dev
https://codereview.appspot.com/10370043

Committer: Rob Pike <r@golang.org>