Issue 103370044: code review 103370044: [release-branch.go1.3] runtime: fix defer of nil func

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103370044: code review 103370044: [release-branch.go1.3] runtime: fix defer of nil func (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by rsc

Modified:
9 years, 10 months ago

Reviewers:
r, gobot, peterGo

CC:
golang-codereviews, r, adg, iant

Visibility:
Public.

Description

[release-branch.go1.3] runtime: fix defer of nil func ««« CL 105140044 / c2832405e9b9 runtime: fix defer of nil func Fixes issue 8047. LGTM=r, iant R=golang-codereviews, r, iant CC=dvyukov, golang-codereviews, khr https://codereview.appspot.com/105140044 »»»

Patch Set 1 #

Patch Set 2 : diff -r bfc80b43b7ff https://code.google.com/p/go/ #

Patch Set 3 : diff -r 53e795419d6b https://code.google.com/p/go/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	src/pkg/runtime/stack.c	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
	A	test/fixedbugs/issue8047b.go	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: adg, iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 10 months ago (2014-06-12 20:49:33 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=3825729c6921 *** [release-branch.go1.3] runtime: fix defer of nil func ««« CL 105140044 ...

9 years, 10 months ago (2014-06-12 20:55:22 UTC) #3

gobot

This CL appears to have broken the windows-amd64 builder. See http://build.golang.org/log/875881ca701c9c82c574a0282f0c36994d7ea7dc

9 years, 10 months ago (2014-06-12 23:57:11 UTC) #4

peterGo

9 years, 10 months ago (2014-06-13 01:01:44 UTC) #5

Message was sent while issue was closed.

Yes, it has: "issue8047b.exe has stopped working."

On 2014/06/12 23:57:11, gobot wrote:
> This CL appears to have broken the windows-amd64 builder.
> See http://build.golang.org/log/875881ca701c9c82c574a0282f0c36994d7ea7dc

Expand All Messages | Collapse All Messages