Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1544)

Issue 103320043: code review 103320043: testing: fix timing format inconsistency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by r
Modified:
9 years, 9 months ago
Reviewers:
r, gobot
CC:
golang-codereviews, r
Visibility:
Public.

Description

testing: fix timing format inconsistency Fixes issue 8175.

Patch Set 1 #

Patch Set 2 : diff -r 6146799f32ed https://code.google.com/p/go #

Patch Set 3 : diff -r 6146799f32ed https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 1282e1d59a81 https://code.google.com/p/go #

Patch Set 5 : diff -r 951cc5f6d52f https://code.google.com/p/go #

Patch Set 6 : diff -r 951cc5f6d52f https://code.google.com/p/go #

Total comments: 1

Patch Set 7 : diff -r 528a025b902b https://code.google.com/p/go #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/pkg/testing/example.go View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/testing/testing.go View 1 2 3 4 5 6 2 chunks +10 lines, -5 lines 2 comments Download

Messages

Total messages: 18
r_varp.se
Hello golang-codereviews@googlegroups.com (cc: r@golang.org), I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-06-11 14:31:05 UTC) #1
r
https://codereview.appspot.com/103320043/diff/40001/src/pkg/testing/example.go File src/pkg/testing/example.go (right): https://codereview.appspot.com/103320043/diff/40001/src/pkg/testing/example.go#newcode74 src/pkg/testing/example.go:74: d := fmt.Sprintf("%.2f seconds", time.Now().Sub(start).Seconds()) I'd prefer you did ...
9 years, 9 months ago (2014-06-11 15:16:06 UTC) #2
r_varp.se
https://codereview.appspot.com/103320043/diff/40001/src/pkg/testing/example.go File src/pkg/testing/example.go (right): https://codereview.appspot.com/103320043/diff/40001/src/pkg/testing/example.go#newcode74 src/pkg/testing/example.go:74: d := fmt.Sprintf("%.2f seconds", time.Now().Sub(start).Seconds()) In that case I ...
9 years, 9 months ago (2014-06-11 16:14:20 UTC) #3
r
I already have a CL outstanding for the formatting of microseconds, although it needs some ...
9 years, 9 months ago (2014-06-11 16:48:46 UTC) #4
r_varp.se
Hello golang-codereviews@googlegroups.com, r@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 9 months ago (2014-06-12 08:14:13 UTC) #5
r_varp.se
Do you think that we should format to some precision, or does this look reasonable? ...
9 years, 9 months ago (2014-06-12 08:15:46 UTC) #6
r
I think the old, two-decimal-point format for the tests was correct, and the right fix ...
9 years, 9 months ago (2014-06-12 15:37:56 UTC) #7
r_varp.se
On 2014/06/12 15:37:56, r wrote: > I think the old, two-decimal-point format for the tests ...
9 years, 9 months ago (2014-06-13 12:57:47 UTC) #8
r_varp.se
Hello golang-codereviews@googlegroups.com, r@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 9 months ago (2014-06-13 12:58:17 UTC) #9
r
https://codereview.appspot.com/103320043/diff/150004/src/pkg/testing/testing.go File src/pkg/testing/testing.go (right): https://codereview.appspot.com/103320043/diff/150004/src/pkg/testing/testing.go#newcode463 src/pkg/testing/testing.go:463: fmt.Printf(format, "PASS", t.name, t.duration, t.output) if you just had ...
9 years, 9 months ago (2014-06-16 19:53:53 UTC) #10
gobot
R=close (assigned by r@golang.org)
9 years, 9 months ago (2014-06-16 20:00:02 UTC) #11
r
R=r not sure why this was closed
9 years, 9 months ago (2014-06-16 20:08:23 UTC) #12
r_varp.se
Hello golang-codereviews@googlegroups.com, r@golang.org, gobot@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 9 months ago (2014-06-17 07:41:07 UTC) #13
r_varp.se
https://codereview.appspot.com/103320043/diff/210001/src/pkg/testing/testing.go File src/pkg/testing/testing.go (right): https://codereview.appspot.com/103320043/diff/210001/src/pkg/testing/testing.go#newcode228 src/pkg/testing/testing.go:228: return fmt.Sprintf("%.2fs", d.Seconds()) Please note that "%.2fs" is not ...
9 years, 9 months ago (2014-06-17 07:41:31 UTC) #14
r_varp.se
Patch Set 7 Output: === RUN TestEmpty --- PASS: TestEmpty (0.00s) === RUN TestNanosecond --- ...
9 years, 9 months ago (2014-06-17 07:42:57 UTC) #15
r
LGTM https://codereview.appspot.com/103320043/diff/210001/src/pkg/testing/testing.go File src/pkg/testing/testing.go (right): https://codereview.appspot.com/103320043/diff/210001/src/pkg/testing/testing.go#newcode228 src/pkg/testing/testing.go:228: return fmt.Sprintf("%.2fs", d.Seconds()) On 2014/06/17 07:41:31, rd wrote: ...
9 years, 9 months ago (2014-06-18 17:58:05 UTC) #16
r
*** Submitted as https://code.google.com/p/go/source/detail?r=f3a39473db21 *** testing: fix timing format inconsistency Fixes issue 8175. LGTM=r R=golang-codereviews, ...
9 years, 9 months ago (2014-06-18 17:58:21 UTC) #17
gobot
9 years, 9 months ago (2014-06-18 18:32:56 UTC) #18
This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/ab67ec29637297bfc0ca67e02baf5500c249f3bc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b