code review 10328044: all: fix shadowing bugs found by go tool vet -shadow

all: fix shadowing bugs found by go tool vet -shadow

[r, 2013-06-20 18:18:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-06-20 18:26:39]

https://codereview.appspot.com/10328044/diff/5001/src/pkg/net/http/client_tes...
File src/pkg/net/http/client_test.go (right):

https://codereview.appspot.com/10328044/diff/5001/src/pkg/net/http/client_tes...
src/pkg/net/http/client_test.go:45: n, err = r.Read(buf)
This doesn't change anything. I think it's more clear as it was, since there's
less scope to reason about.

https://codereview.appspot.com/10328044/diff/5001/src/pkg/os/file_unix.go
File src/pkg/os/file_unix.go (right):

https://codereview.appspot.com/10328044/diff/5001/src/pkg/os/file_unix.go#new...
src/pkg/os/file_unix.go:161: var fip FileInfo
I don't think this is right yet.  If len(names) > 1 and the first Lstat fails
but a later one does not, that error is now lost.

We need something like:

fip, lerr := Lstat(...)
if err == nil {
    err = lerr
}
....

Or we need to return earlier on failure.

[r, 2013-06-20 18:31:18]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-06-20 18:31:28]

https://codereview.appspot.com/10328044/diff/5001/src/pkg/net/http/client_tes...
File src/pkg/net/http/client_test.go (right):

https://codereview.appspot.com/10328044/diff/5001/src/pkg/net/http/client_tes...
src/pkg/net/http/client_test.go:45: n, err = r.Read(buf)
On 2013/06/20 18:26:39, bradfitz wrote:
> This doesn't change anything. I think it's more clear as it was, since there's
> less scope to reason about.

Done.

[bradfitz, 2013-06-20 18:43:01]

LGTM

[r, 2013-06-20 18:50:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=caa09ce4fd8b ***

all: fix shadowing bugs found by go tool vet -shadow

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/10328044