Issue 1032044: code review 1032044: gc: be pickier about slice, chan, array, and map sizes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1032044: code review 1032044: gc: be pickier about slice, chan, array, and map sizes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

gc: be pickier about slice, chan, array, and map sizes Fixes issue 589.

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -60 lines)			Patch
M	src/cmd/gc/align.c	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	src/cmd/gc/builtin.c.boot	View		3 chunks	+29 lines, -29 lines	0 comments	Download
M	src/cmd/gc/runtime.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/cmd/gc/walk.c	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/chan.c	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/slice.c	View	1	2 chunks	+11 lines, -8 lines	0 comments	Download
A	test/fixedbugs/bug273.go	View		1 chunk	+95 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-05-01 20:15:40 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=6e5530c00b24 *** gc: be pickier about slice, chan, array, and map sizes ...

15 years ago (2010-05-01 20:15:44 UTC) #2

LGTM