Issue 10320043: code review 10320043: os: rename error_posix.go to error_unix.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10320043: code review 10320043: os: rename error_posix.go to error_unix.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dave

Modified:
11 years, 9 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

os: rename error_posix.go to error_unix.go The tradition is to use _posix when the platform extends beyond unix variants. As windows has its own file, rename to the more usual _unix.

Patch Set 1 #

Patch Set 2 : diff -r 2879112bff3d https://code.google.com/p/go #

Patch Set 3 : diff -r 56909cb770fe https://code.google.com/p/go #

Patch Set 4 : diff -r d04e6b0bcacf https://code.google.com/p/go #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	M	src/pkg/os/error_unix.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 9 months ago (2013-06-22 08:13:21 UTC) #1

dave_cheney.net

11 years, 9 months ago (2013-06-24 01:23:53 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5b2b5f8d89b0 ***

os: rename error_posix.go to error_unix.go

The tradition is to use _posix when the platform extends beyond unix variants.
As windows has its own file, rename to the more usual _unix.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10320043

Expand All Messages | Collapse All Messages