Issue 10310043: code review 10310043: crypto/cipher: StreamWriter.Closer docs + behavior change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10310043: code review 10310043: crypto/cipher: StreamWriter.Closer docs + behavior change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 9 months ago

Reviewers:
agl1

CC:
golang-dev, agl1

Visibility:
Public.

Description

crypto/cipher: StreamWriter.Closer docs + behavior change Don't panic when the underlying Writer isn't a Closer. And document what Close does and clarify that it's not a Flush.

Patch Set 1 #

Patch Set 2 : diff -r a40ef06e2106 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a40ef06e2106 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 330478300ab0 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 330478300ab0 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r e343cfbb0210 https://go.googlecode.com/hg/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/pkg/crypto/cipher/io.go	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2013-06-15 23:41:12 UTC) #1

bradfitz

11 years, 9 months ago (2013-06-17 14:30:10 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=91417c99fd59 ***

crypto/cipher: StreamWriter.Closer docs + behavior change

Don't panic when the underlying Writer isn't a Closer. And
document what Close does and clarify that it's not a Flush.

R=golang-dev, agl
CC=golang-dev
https://codereview.appspot.com/10310043

Expand All Messages | Collapse All Messages