Issue 103020044: code review 103020044: compress/gzip: allow Reset on Reader without NewReader

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 103020044: code review 103020044: compress/gzip: allow Reset on Reader without NewReader (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by iant

Modified:
9 years, 11 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

compress/gzip: allow Reset on Reader without NewReader Fixes issue 8126.

Patch Set 1 #

Patch Set 2 : diff -r a078b2056ebc https://code.google.com/p/go #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/pkg/compress/gzip/gunzip.go	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	src/pkg/compress/gzip/gunzip_test.go	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 11 months ago (2014-06-03 16:50:50 UTC) #1

iant

9 years, 11 months ago (2014-06-03 22:40:14 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=318b56ffe04b ***

compress/gzip: allow Reset on Reader without NewReader

Fixes issue 8126.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/103020044

Expand All Messages | Collapse All Messages