code review 102470046: net: Don't read beyond end of slice when parsing re...

net: Don't read beyond end of slice when parsing resolv.conf options.

Fixes issue 8252.

[ruiu, 2014-06-24 05:27:15]

Is this ready for review? If so you want run "hg mail" to
sent it to the mailing list.

https://codereview.appspot.com/102470046/diff/20001/src/pkg/net/dnsconfig_uni...
File src/pkg/net/dnsconfig_unix.go (right):

https://codereview.appspot.com/102470046/diff/20001/src/pkg/net/dnsconfig_uni...
src/pkg/net/dnsconfig_unix.go:90: case len(s) >= 9 && s[0:9] == "attempts:":
I'd define hasPrefix(s, prefix string) bool instead of doing it inline.

[jborg, 2014-07-03 11:54:49]

Hello ruiu@google.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[josharian, 2014-07-03 17:00:42]

https://codereview.appspot.com/102470046/diff/60001/src/pkg/net/dnsconfig_uni...
File src/pkg/net/dnsconfig_unix.go (right):

https://codereview.appspot.com/102470046/diff/60001/src/pkg/net/dnsconfig_uni...
src/pkg/net/dnsconfig_unix.go:108: return len(s) >= len(prefix) &&
s[0:len(prefix)] == prefix
You can omit the 0 in the slice; :len(prefix) is enough. (I suspect that this
code was written before the 0 was implicit.)

[adg, 2014-07-15 04:43:55]

LGTM

[adg, 2014-07-15 04:49:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=5207b394de96 ***

net: Don't read beyond end of slice when parsing resolv.conf options.

Fixes issue 8252.

LGTM=adg
R=ruiu, josharian, adg
CC=golang-codereviews
https://codereview.appspot.com/102470046

Committer: Andrew Gerrand <adg@golang.org>

[gobot, 2014-07-15 05:58:30]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/1fadda101f2aec1097883c4a466d7b414de77a43

[adg, 2014-07-15 06:01:08]

On 15 July 2014 15:58, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/1fadda101f2aec1097883c4a466d7b414de77a43
>

false