Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 102100043: code review 102100043: [release-branch.go1.3] cmd/cgo: use same Go type for ty... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by dsymonds
Modified:
9 years, 10 months ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] cmd/cgo: use same Go type for typedef to anonymous struct ««« CL 102080043 / 256d975c53cb cmd/cgo: use same Go type for typedef to anonymous struct If we see a typedef to an anonymous struct more than once, presumably in two different Go files that import "C", use the same Go type name. Fixes issue 8133. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/102080043 »»»

Patch Set 1 #

Patch Set 2 : diff -r ad62368a0c24 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
A misc/cgo/test/issue8331.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
A misc/cgo/test/issue8331a.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
A misc/cgo/test/issue8331b.go View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
dsymonds
Hello adg (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2014-06-03 01:17:57 UTC) #1
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=317d45e3c8db *** [release-branch.go1.3] cmd/cgo: use same Go type for typedef to anonymous ...
9 years, 10 months ago (2014-06-03 01:18:08 UTC) #2
adg
9 years, 10 months ago (2014-06-03 01:19:55 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b