Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3794)

Issue 102030043: code review 102030043: encoding/json: Marshal should use the last available va... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by oneofone
Modified:
9 years, 6 months ago
Reviewers:
golang-codereviews
Visibility:
Public.

Description

encoding/json: Marshal should use the last available value of duplicates instead of deleting the field While the spec doesn't specify what to do with duplicate keys, most implementations (V8, Python) will just use the last available value instead of deleting the key all together. Updated the tests for the change and added the test case from 8121. Fixes issue 8121.

Patch Set 1 #

Patch Set 2 : diff -r 5bf1a8b3aeea https://code.google.com/p/go #

Patch Set 3 : diff -r 5bf1a8b3aeea https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M src/pkg/encoding/json/decode_test.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/encoding/json/encode.go View 1 2 chunks +3 lines, -8 lines 0 comments Download
M src/pkg/encoding/json/encode_test.go View 1 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 3
oneofone
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2014-05-30 13:57:00 UTC) #1
oneofone
On 2014/05/30 13:57:00, oneofone wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
9 years, 8 months ago (2014-07-07 03:22:16 UTC) #2
oneofone
9 years, 8 months ago (2014-07-07 06:13:01 UTC) #3
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b