Issue 10182044: net: fix LookupNS on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10182044: net: fix LookupNS on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by mischief

Modified:
11 years, 7 months ago

Reviewers:
ality

CC:
golang-dev, ality

Visibility:
Public.

Description

net: fix LookupNS on Plan 9 use correct field count when resolving nameservers via /net/dns on Plan 9. we incorrectly check for 4 fields instead of 3 when parsing the result of /net/dns, and get no results

Patch Set 1 #

Patch Set 2 : diff -r 50b14678c440 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 50b14678c440 https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/net/lookup_plan9.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mischief

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 9 months ago (2013-06-11 11:38:55 UTC) #1

ality

LGTM Please mention LookupNS in the first line of the CL description. Something like "net: ...

11 years, 9 months ago (2013-06-12 15:04:46 UTC) #2

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=bc84bcc515f9 *** net: fix LookupNS on Plan 9 use correct field count ...

11 years, 9 months ago (2013-06-17 18:38:17 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages