Issue 101800043: code review 101800043: runtime: stack copier should handle nil defers without ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 101800043: code review 101800043: runtime: stack copier should handle nil defers without ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by khr

Modified:
9 years, 11 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

runtime: stack copier should handle nil defers without faulting. fixes issue 8047

Patch Set 1 #

Patch Set 2 : diff -r e165495e81bf https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r e165495e81bf https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r e165495e81bf https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r e165495e81bf https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 6 : diff -r ff1ee73dfa01 https://khr%40golang.org@code.google.com/p/go/ #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/pkg/runtime/stack.c	View	1 2 3 4	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

9 years, 11 months ago (2014-05-27 20:41:09 UTC) #1

khr

9 years, 11 months ago (2014-05-27 23:26:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fab13f974d05 ***

runtime: stack copier should handle nil defers without faulting.

fixes issue 8047

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/101800043

Expand All Messages | Collapse All Messages