Issue 10141044: code review 10141044: go.tools/go/types: fix isAssignable and IsIdentical

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10141044: code review 10141044: go.tools/go/types: fix isAssignable and IsIdentical (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by gri

Modified:
10 years, 10 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types: fix isAssignable and IsIdentical - Imported objects that are explicitly exported may have a nil package; don't use it for qualified name computation (it's not needed). - isAssignable must check all possibilities before declaring failure. Fixes issue 5675.

Patch Set 1 #

Patch Set 2 : diff -r 072a54c443ec https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 072a54c443ec https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 072a54c443ec https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 072a54c443ec https://code.google.com/p/go.tools #

Patch Set 6 : diff -r 072a54c443ec https://code.google.com/p/go.tools #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
	M	go/types/operand.go	View	1 2	1 chunk	+7 lines, -6 lines	0 comments	Download
	M	go/types/predicates.go	View	1	3 chunks	+21 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 10 months ago (2013-06-11 01:02:54 UTC) #1

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 10 months ago (2013-06-11 16:50:30 UTC) #2

adonovan

On 2013/06/11 16:50:30, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...

10 years, 10 months ago (2013-06-11 16:55:39 UTC) #3

gri

10 years, 10 months ago (2013-06-11 17:00:03 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=eeb58a9dd66a&repo=tools ***

go.tools/go/types: fix isAssignable and IsIdentical

- Imported objects that are explicitly exported may have a nil package;
  don't use it for qualified name computation (it's not needed).
- isAssignable must check all possibilities before declaring failure.

Fixes issue 5675.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/10141044

Expand All Messages | Collapse All Messages