code review 10134044: go.net/proxy: fix SOCSK5 user/pass auth.

go.net/proxy: fix SOCSK5 user/pass auth.

The code was using the SOCKS version number (5) where it should have been using the username/password protocol version number (1).

With this change, username/password authentication actually works.

[agl1, 2013-06-09 17:22:01]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net/

[agl1, 2013-06-09 17:22:28]

*** Submitted as
https://code.google.com/p/go/source/detail?r=64ee4bbc10fa&repo=net ***

go.net/proxy: fix SOCSK5 user/pass auth.

The code was using the SOCKS version number (5) where it should have been using
the username/password protocol version number (1).

With this change, username/password authentication actually works.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/10134044

[bradfitz, 2013-06-09 17:24:22]

LGTM



On Sun, Jun 9, 2013 at 7:22 PM, <agl@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**net/ <https://code.google.com/p/go.net/>
>
>
> Description:
> go.net/proxy: fix SOCSK5 user/pass auth.
>
> The code was using the SOCKS version number (5) where it should have
> been using the username/password protocol version number (1).
>
> With this change, username/password authentication actually works.
>
> Please review this at
https://codereview.appspot.**com/10134044/<https://codereview.appspot.com/101...
>
> Affected files:
>   M proxy/socks5.go
>
>
> Index: proxy/socks5.go
> ==============================**==============================**=======
> --- a/proxy/socks5.go
> +++ b/proxy/socks5.go
> @@ -118,7 +118,7 @@
>
>         if buf[1] == socks5AuthPassword {
>                 buf = buf[:0]
> -               buf = append(buf, socks5Version)
> +               buf = append(buf, 1 /* password protocol version */)
>                 buf = append(buf, uint8(len(s.user)))
>                 buf = append(buf, s.user...)
>                 buf = append(buf, uint8(len(s.password)))
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>