Issue 101260044: code review 101260044: runtime: fix VDSO lookup to use dynamic hash table

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 101260044: code review 101260044: runtime: fix VDSO lookup to use dynamic hash table (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by iant

Modified:
9 years, 10 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, mattn, rsc

Visibility:
Public.

Description

runtime: fix VDSO lookup to use dynamic hash table Reportedly in the Linux 3.16 kernel the VDSO will not have section headers or a normal symbol table. Too late for 1.3 but perhaps for 1.3.1, if there is one. Fixes issue 8197.

Patch Set 1 #

Patch Set 2 : diff -r bef07f7786d6 https://code.google.com/p/go #

Patch Set 3 : diff -r 83e5cc3f003d https://code.google.com/p/go #

Patch Set 4 : diff -r 83e5cc3f003d https://code.google.com/p/go #

Patch Set 5 : diff -r 83e5cc3f003d https://code.google.com/p/go #

Patch Set 6 : diff -r f70ac618569d https://code.google.com/p/go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -31 lines)			Patch
	M	src/pkg/runtime/vdso_linux_amd64.c	View	1 2 3 4 5	9 chunks	+60 lines, -31 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

iant

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 11 months ago (2014-06-12 21:28:26 UTC) #1

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=fc1cd5e12595 *** runtime: fix VDSO lookup to use dynamic hash table Reportedly ...

9 years, 10 months ago (2014-06-13 20:29:30 UTC) #4

gobot

This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/de1809c40f74f127055a439e8b343a792730c761

9 years, 10 months ago (2014-06-13 20:44:53 UTC) #5

iant

9 years, 10 months ago (2014-06-13 21:09:28 UTC) #6

On Fri, Jun 13, 2014 at 1:44 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/de1809c40f74f127055a439e8b343a792730c761
>
> https://codereview.appspot.com/101260044/

Does not look real.

Ian

Expand All Messages | Collapse All Messages