Issue 10125044: code review 10125044: go.net/ipv4: add datagram benchmark

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10125044: code review 10125044: go.net/ipv4: add datagram benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by mikio

Modified:
10 years, 10 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

go.net/ipv4: add datagram benchmark Current result on darwin/amd64: BenchmarkReadWriteNetUDP-2 100000 16112 ns/op 330 B/op 6 allocs/op BenchmarkReadWriteIPv4UDP-2 200000 14337 ns/op 654 B/op 14 allocs/op Update issue 3684

Patch Set 1 : diff -r da2eb5dd9ea9 https://code.google.com/p/go.net #

Patch Set 2 : diff -r da2eb5dd9ea9 https://code.google.com/p/go.net #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -0 lines)			Patch
	M	ipv4/unicast_test.go	View		1 chunk	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 10 months ago (2013-06-16 06:53:30 UTC) #1

dave_cheney.net

LGTM. Numbers are much better on linux/amd64 PASS BenchmarkReadWriteNetUDP 500000 4513 ns/op BenchmarkReadWriteIPv4UDP 500000 7679 ...

10 years, 10 months ago (2013-06-16 07:27:14 UTC) #2

mikio

10 years, 10 months ago (2013-06-16 07:58:37 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=b8dd04764dae&repo=net ***

go.net/ipv4: add datagram benchmark

Current result on darwin/amd64:
BenchmarkReadWriteNetUDP-2	  100000	     16112 ns/op	     330 B/op	       6
allocs/op
BenchmarkReadWriteIPv4UDP-2	  200000	     14337 ns/op	     654 B/op	      14
allocs/op

Update issue 3684

R=dave
CC=golang-dev
https://codereview.appspot.com/10125044

Expand All Messages | Collapse All Messages