Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2751)

Issue 10110043: code review 10110043: cmd/go: update go vet documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by rog
Modified:
10 years, 11 months ago
Reviewers:
r
CC:
rsc, minux1, r, golang-dev
Visibility:
Public.

Description

cmd/go: update go vet documentation

Patch Set 1 #

Patch Set 2 : diff -r 4aa7943034c5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4aa7943034c5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4aa7943034c5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/go/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/go/vet.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
rog
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 11 months ago (2013-06-07 08:07:08 UTC) #1
minux1
change looks good, do you also want to mention how to update (or install) vet ...
10 years, 11 months ago (2013-06-07 09:47:19 UTC) #2
rog
Good question. I'll await consensus on that. On 7 June 2013 10:47, minux <minux.ma@gmail.com> wrote: ...
10 years, 11 months ago (2013-06-07 12:36:55 UTC) #3
r
might as well say how to install it too, although "go vet" will also remind ...
10 years, 11 months ago (2013-06-07 15:30:17 UTC) #4
minux1
On Friday, June 7, 2013, r wrote: > might as well say how to install ...
10 years, 11 months ago (2013-06-07 15:36:10 UTC) #5
r
LGTM with updated URL only
10 years, 11 months ago (2013-06-07 15:42:18 UTC) #6
r
How about doing nothing now, since it's all changing anyway? We'll only have to come ...
10 years, 11 months ago (2013-06-07 15:42:23 UTC) #7
minux1
On Friday, June 7, 2013, Rob Pike wrote: > How about doing nothing now, since ...
10 years, 11 months ago (2013-06-07 15:58:39 UTC) #8
rog
10 years, 11 months ago (2013-06-07 18:01:33 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=3378d2483995 ***

cmd/go: update go vet documentation

R=rsc, minux.ma, r
CC=golang-dev
https://codereview.appspot.com/10110043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b