Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1530)

Issue 100930044: code review 100930044: time: support version 3 zone records (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by bradfitz
Modified:
9 years, 10 months ago
Reviewers:
gobot, adg, iant
CC:
golang-codereviews, iant, r, rsc
Visibility:
Public.

Description

time: support version 3 zone records Fixes Issue 8134

Patch Set 1 #

Patch Set 2 : diff -r 1bec455e95f1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1bec455e95f1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1bec455e95f1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/pkg/time/zoneinfo_read.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/time/zoneinfo_test.go View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9
bradfitz
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, r@golang.org, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 10 months ago (2014-06-03 01:46:55 UTC) #1
iant
LGTM
9 years, 10 months ago (2014-06-03 02:35:30 UTC) #2
bradfitz
Should I submit or wait for more reviews? I'm being paranoid because of where we ...
9 years, 10 months ago (2014-06-03 02:36:52 UTC) #3
iant
On Mon, Jun 2, 2014 at 7:36 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Should I ...
9 years, 10 months ago (2014-06-03 02:39:22 UTC) #4
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=fde405c62fca *** time: support version 3 zone records Fixes Issue 8134 LGTM=iant ...
9 years, 10 months ago (2014-06-03 02:44:17 UTC) #5
bradfitz
SGTM I'll leave to others to cherry-pick into the release branch if desired. On Tue, ...
9 years, 10 months ago (2014-06-03 02:44:48 UTC) #6
gobot
This CL appears to have broken the nacl-amd64p32 builder. See http://build.golang.org/log/15a7bcdf47380eb2d139f707cbc78ac7c22cb4ff
9 years, 10 months ago (2014-06-03 03:03:12 UTC) #7
adg
On 3 June 2014 12:44, Brad Fitzpatrick <bradfitz@golang.org> wrote: > I'll leave to others to ...
9 years, 10 months ago (2014-06-03 03:26:00 UTC) #8
rsc
9 years, 10 months ago (2014-06-03 05:51:09 UTC) #9
Yes, this should go into the release branch. I will add it when I add my
escape analysis fix if no one beats me to it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b