Issue 100560043: code review 100560043: database/sql: more docs explaining that DB is a pool

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 100560043: code review 100560043: database/sql: more docs explaining that DB is a pool (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by bradfitz

Modified:
9 years, 11 months ago

Reviewers:
r, gobot

CC:
r, golang-codereviews

Visibility:
Public.

Description

database/sql: more docs explaining that DB is a pool This is the main point of confusion and the emphasis of a recent Gophercon talk. Fixes Issue 5886. (mostly fixed in previous commits)

Patch Set 1 #

Patch Set 2 : diff -r 0d7a1ac60a57 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0d7a1ac60a57 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0d7a1ac60a57 https://go.googlecode.com/hg/ #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/pkg/database/sql/sql.go	View	1	3 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 11 months ago (2014-05-19 16:44:07 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=62840fa688d8 *** database/sql: more docs explaining that DB is a pool This ...

9 years, 11 months ago (2014-05-19 16:54:49 UTC) #3

gobot

9 years, 11 months ago (2014-05-19 17:24:22 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/65f41867f9afa5d4ee1ca157901d0bdfd77ba724

Expand All Messages | Collapse All Messages