Issue 10033043: code review 10033043: [release-branch.go1.1] cmd/gc: fix missing slice/array ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10033043: code review 10033043: [release-branch.go1.1] cmd/gc: fix missing slice/array ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adg

Modified:
10 years, 10 months ago

Reviewers:
dsymonds, rsc

CC:
iant, remyoudompheng, dsymonds, golang-dev

Visibility:
Public.

Description

[release-branch.go1.1] cmd/gc: fix missing slice/array types in export data. ««« CL 9953044 / 0e1b2f7384d2 cmd/gc: fix missing slice/array types in export data. Fixes issue 5614. R=golang-dev CC=golang-dev https://codereview.appspot.com/9953044 »»»

Patch Set 1 #

Patch Set 2 : diff -r b88e87d911e1 https://code.google.com/p/go #

Patch Set 3 : diff -r b88e87d911e1 https://code.google.com/p/go #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
src/cmd/gc/export.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
test/fixedbugs/issue5614.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
test/fixedbugs/issue5614.dir/rethinkgo.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
test/fixedbugs/issue5614.dir/x.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
test/fixedbugs/issue5614.dir/y.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello iant, remyoudompheng (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 10 months ago (2013-06-05 01:14:34 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=589ca7cb68bf *** [release-branch.go1.1] cmd/gc: fix missing slice/array types in export data. ««« ...

10 years, 10 months ago (2013-06-05 01:19:34 UTC) #3

LGTM

Expand All Messages | Collapse All Messages