Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 10028044: code review 10028044: [release-branch.go1.1] runtime: fix heap corruption dur... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adg
Modified:
10 years, 9 months ago
Reviewers:
rsc, dfc
CC:
dvyukov, khr, dfc, golang-dev
Visibility:
Public.

Description

[release-branch.go1.1] runtime: fix heap corruption during GC ««« CL 9831043 / e84e7204b01b runtime: fix heap corruption during GC The 'n' variable is used during rescan initiation in GC_END case, but it's overwritten with chan capacity in GC_CHAN case. As the result rescan is done with the wrong object size. Fixes issue 5554. R=golang-dev, khr CC=golang-dev https://codereview.appspot.com/9831043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 7d8b2bbe53e5 https://code.google.com/p/go #

Patch Set 3 : diff -r 7d8b2bbe53e5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M src/pkg/runtime/gc_test.go View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
adg
Hello dvyukov, khr (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2013-06-05 01:09:26 UTC) #1
dfc
LGTM. On Wed, Jun 5, 2013 at 11:09 AM, <adg@golang.org> wrote: > Reviewers: dvyukov, khr, ...
10 years, 9 months ago (2013-06-05 01:10:18 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=b88e87d911e1 *** [release-branch.go1.1] runtime: fix heap corruption during GC ««« CL 9831043 ...
10 years, 9 months ago (2013-06-05 01:12:53 UTC) #3
rsc
10 years, 9 months ago (2013-06-10 11:50:39 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b