Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4001)

Issue 10027043: code review 10027043: [release-branch.go1.1] runtime: fix GC scanning of slices (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by adg
Modified:
10 years, 9 months ago
Reviewers:
rsc, iant
CC:
cshapiro1, iant, golang-dev
Visibility:
Public.

Description

[release-branch.go1.1] runtime: fix GC scanning of slices ««« CL 9372044 / 1abed5873071 runtime: fix GC scanning of slices If a slice points to an array embedded in a struct, the whole struct can be incorrectly scanned as the slice buffer. Fixes issue 5443. R=cshapiro, iant, r, cshapiro, minux.ma CC=bradfitz, gobot, golang-dev https://codereview.appspot.com/9372044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 6fd05e0b4f08 https://code.google.com/p/go #

Patch Set 3 : diff -r 6fd05e0b4f08 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M src/pkg/runtime/gc_test.go View 1 1 chunk +24 lines, -0 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
adg
Hello cshapiro1, iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2013-06-05 00:03:25 UTC) #1
iant
LGTM
10 years, 9 months ago (2013-06-05 00:08:00 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=b7405fc44ff7 *** [release-branch.go1.1] runtime: fix GC scanning of slices ««« CL 9372044 ...
10 years, 9 months ago (2013-06-05 00:20:41 UTC) #3
rsc
10 years, 9 months ago (2013-06-10 11:48:33 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b