code review 10024044: undo CL 10017045 / 6ec8c49421a0

undo CL 10017045 / 6ec8c49421a0

It was never tested and also breaks Windows.

run.go doesn't yet support the proper !windows,!plan9 syntax.

««« original CL description
test: do not run SIGCHLD test on Plan 9

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/10017045
»»»

[bradfitz, 2013-06-05 04:49:44]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2013-06-05 04:51:06]

LGTM.

On Wed, Jun 5, 2013 at 2:49 PM,  <bradfitz@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> undo CL 10017045 / 6ec8c49421a0
>
> It was never tested and also breaks Windows.
>
> run.go doesn't yet support the proper !windows,!plan9 syntax.
>
> ««« original CL description
> test: do not run SIGCHLD test on Plan 9
>
> R=golang-dev, bradfitz
> CC=golang-dev
> https://codereview.appspot.com/10017045
> »»»
>
> Please review this at https://codereview.appspot.com/10024044/
>
> Affected files:
>   M test/sigchld.go
>
>
> Index: test/sigchld.go
> ===================================================================
> --- a/test/sigchld.go
> +++ b/test/sigchld.go
> @@ -1,4 +1,4 @@
> -// +build !windows !plan9
> +// +build !windows
>  // cmpout
>
>  // Copyright 2009 The Go Authors. All rights reserved.
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[bradfitz, 2013-06-05 04:51:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=24deeb374803 ***

undo CL 10017045 / 6ec8c49421a0

It was never tested and also breaks Windows.

run.go doesn't yet support the proper !windows,!plan9 syntax.

««« original CL description
test: do not run SIGCHLD test on Plan 9

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/10017045
»»»

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/10024044