code review 100180043: cmd/addr2line: skip broken TestAddr2Line on plan9 (fixe...

cmd/addr2line: skip broken TestAddr2Line on plan9 (fixes build)

Update issue 7947

[brainman, 2014-05-07 01:55:37]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-05-07 01:56:48]

LGTM
 On May 6, 2014 6:55 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/addr2line: skip broken TestAddr2Line on plan9 (fixes build)
>
> Update issue 7947
>
> Please review this at https://codereview.appspot.com/100180043/
>
> Affected files (+3, -0 lines):
>   M src/cmd/addr2line/addr2line_test.go
>
>
> Index: src/cmd/addr2line/addr2line_test.go
> ===================================================================
> --- a/src/cmd/addr2line/addr2line_test.go
> +++ b/src/cmd/addr2line/addr2line_test.go
> @@ -68,6 +68,9 @@
>  }
>
>  func TestAddr2Line(t *testing.T) {
> +       if runtime.GOOS == "plan9" {
> +               t.Skip("skipping test; see http://golang.org/issue/7947")
> +       }
>         syms := loadSyms(t)
>
>         tmpDir, err := ioutil.TempDir("", "TestAddr2Line")
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[brainman, 2014-05-07 01:58:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=b359cdd4e66e ***

cmd/addr2line: skip broken TestAddr2Line on plan9 (fixes build)

Update issue 7947

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/100180043