Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: windows mkMode should set 0111 for dirs #4444

Closed
rsc opened this issue Nov 26, 2012 · 5 comments
Closed

os: windows mkMode should set 0111 for dirs #4444

rsc opened this issue Nov 26, 2012 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.1

Comments

@rsc
Copy link
Contributor

rsc commented Nov 26, 2012 

mkMode returns mode 0444 or 0666 for directories on Windows. It should set the 0111 bits
too, for consistency with Unix modes. (If we're going to simulate them the simulation
should be more faithful.)

The current behavior leads to strange behaviors like creating zip files from Windows
with directories mode 0666, which then means that when unzipped on Unix the directories
are unusable.
@alexbrainman
Copy link
Member

Comment 1:

http://golang.org/cl/6858079/

Status changed to Started.

@alexbrainman
Copy link
Member

Comment 2:

This issue was closed by revision 5b65023.

Status changed to Fixed.

@gopherbot
Copy link

Comment 3:

The permissions on my Linux machine of directory src/pkg/os are 0400. os_test.go fails
with the following message:
--- FAIL: TestStatDirModeExec-2 (0.00 seconds)
os_test.go:1107:        Stat ".": mode 020000000700 want 0111
FAIL

@bradfitz
Copy link
Contributor

Comment 4:

Open a new bug and link it here.

@alexbrainman
Copy link
Member

Comment 5:

How about this https://golang.org/cl/6851129/ ?
Alex

@rsc rsc added fixed labels Nov 30, 2012
@rsc rsc self-assigned this Nov 30, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
4 participants
@bradfitz @rsc @gopherbot @alexbrainman