Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: gc_test failing frequently on 32 bit systems #4155

Closed
davecheney opened this issue Sep 26, 2012 · 14 comments
Closed

runtime: gc_test failing frequently on 32 bit systems #4155

davecheney opened this issue Sep 26, 2012 · 14 comments
Labels
FrozenDueToAge
Milestone
Go1.2

Comments

@davecheney
Copy link
Contributor 

What steps will reproduce the problem?

32 bit systems are failing late in the build with this error.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestGcSys-4 (1.17 seconds)
gc_test.go:36:  used 17694720 extra bytes
gc_test.go:38:  using too much memory: 17694720 bytes

What is the expected output? What do you see instead?

Test pass

Please use labels and text to provide additional information.

The test became more unstable after
https://code.google.com/p/go/source/detail?r=56f5a223dcd7a238faa8afb45cd800ed4fe0dcdc.
I'm not saying that this commit caused the problem, but it may have destabilised things.
@robpike
Copy link
Contributor

robpike commented Sep 26, 2012

Comment 1:

Labels changed: added priority-soon, removed priority-triage.

@rsc
Copy link
Contributor

rsc commented Oct 6, 2012

Comment 2:

Labels changed: added go1.1.

@remyoudompheng
Copy link
Contributor

Comment 3:

In non short mode, the test fails almost every time. It's because ParForParallel
allocates a giant block and delays GC too much.
I don't understand if it's the same problem in short mode.

@minux
Copy link
Member

minux commented Oct 7, 2012

Comment 4:

oh, great, thank you for the hint.
i disabled TestParForParallel, and run -short test 10 times, all without failure.
i then applied atom's precise GC patch and forced a GC() after that test, again,
10 times without failure.

@davecheney
Copy link
Contributor Author

Comment 5:

I haven't seen this failure recently.

Status changed to Fixed.

@minux
Copy link
Member

minux commented Mar 2, 2013

Comment 6:

rev 05b050bdd4a0 says:
When we have precise GC merged, re-enable this test (TestParForParallel) on 32-bit
platforms.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Mar 11, 2013

Comment 7:

Want to re-enable the test, then? It's not completely precise but it should be much
better (all but stack).

@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 8:

[The time for maybe has passed.]

@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 9:

Labels changed: added go1.1maybe, removed go1.1.

@robpike
Copy link
Contributor

robpike commented May 18, 2013

Comment 10:

Labels changed: added go1.2maybe, removed go1.1maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 11:

minux, can the test be re-enabled?

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 12:

Labels changed: added feature.

@robpike
Copy link
Contributor

robpike commented Aug 29, 2013

Comment 13:

Status changed to Started.

@robpike
Copy link
Contributor

robpike commented Aug 29, 2013

Comment 14:

This issue was closed by revision 7c7d22a.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
6 participants
@davecheney @rsc @minux @remyoudompheng @robpike @gopherbot