Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go, cmd/gc: reject import paths containing special characters #3021

Closed
rsc opened this issue Feb 14, 2012 · 3 comments
Closed

cmd/go, cmd/gc: reject import paths containing special characters #3021

rsc opened this issue Feb 14, 2012 · 3 comments
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Feb 14, 2012

Discussion during CL 5674043.

Plan is to reject control characters (including \x00 and \x7F), spaces,
invalid UTF-8 encodings, and !"#$%&'()*,:;<=>?[\]^`{|}~

Need to put rules in compiler, go/parser, and spec (implementation restriction).
@gopherbot
Copy link

Comment 1 by untheoretic:

I would say, please just allow a..z_-
But I know a lot of humans who write notes
as directory or file names.

@griesemer
Copy link
Contributor

Comment 2:

http://golang.org/cl/5683077  go/parser
http://golang.org/cl/5688074  go spec

@ality
Copy link
Member

ality commented Feb 24, 2012

Comment 3:

This issue was closed by revision dc38756.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 24, 2012
@rsc rsc self-assigned this Feb 24, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants