code review 6847125: encoding/base64: new example for NewEncoder with emphas...

encoding/base64: new example for NewEncoder with emphasis on Close
Fixes issue 4394.

[minux1, 2012-11-29 12:25:05]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2012-11-29 14:46:52]

https://codereview.appspot.com/6847125/diff/5001/src/pkg/encoding/base64/exam...
File src/pkg/encoding/base64/example_test.go (right):

https://codereview.appspot.com/6847125/diff/5001/src/pkg/encoding/base64/exam...
src/pkg/encoding/base64/example_test.go:38: // Please try comment the following
line and see what happens?
Since this is essentially documentation I think it would be more helpful to say
// If you comment out the following line, [this will happen]

[minux1, 2012-11-30 16:50:46]

PTAL.

On 2012/11/29 14:46:52, iant wrote:
>
https://codereview.appspot.com/6847125/diff/5001/src/pkg/encoding/base64/exam...
> src/pkg/encoding/base64/example_test.go:38: // Please try comment the
following
> line and see what happens?
> Since this is essentially documentation I think it would be more helpful to
say
> // If you comment out the following line, [this will happen]
Done.

[bradfitz, 2012-12-01 23:18:41]

LGTM

[rsc, 2012-12-09 10:21:50]

Minux, want to submit?

[Miek Gieben, 2012-12-10 21:08:24]

On 2012/12/09 10:21:50, rsc wrote:
> Minux, want to submit?

Could base32 also benefit from this documentation?

[rsc, 2012-12-11 16:32:06]

Will add a base32 example and submit.

[rsc, 2012-12-11 16:49:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=135ee8a96653 ***

encoding/base64: new example for NewEncoder with emphasis on Close
Fixes issue 4394.

R=iant, bradfitz, rsc, remigius.gieben
CC=golang-dev
https://codereview.appspot.com/6847125

Committer: Russ Cox <rsc@golang.org>