Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1620)

Issue 6847107: code review 6847107: regexp: add examples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by volker.dobler
Modified:
11 years, 4 months ago
Reviewers:
CC:
minux1, rsc, golang-dev
Visibility:
Public.

Description

regexp: add examples Update issue 4125

Patch Set 1 #

Patch Set 2 : diff -r fc4e67d82024 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fc4e67d82024 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 448fb06d74ee https://code.google.com/p/go/ #

Total comments: 12

Patch Set 5 : diff -r 448fb06d74ee https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M src/pkg/regexp/example_test.go View 1 2 3 4 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 7
volker.dobler
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 4 months ago (2012-11-26 09:44:47 UTC) #1
minux1
your local hg tree if out-of-date, please do hg sync hg mail 6847107
11 years, 4 months ago (2012-11-26 12:05:26 UTC) #2
volker.dobler
PTAL
11 years, 4 months ago (2012-11-26 12:14:22 UTC) #3
rsc
Looks good, but let's use %q for all []string and [][]string prints. Thanks. https://codereview.appspot.com/6847107/diff/5002/src/pkg/regexp/example_test.go File ...
11 years, 4 months ago (2012-11-26 19:17:52 UTC) #4
volker.dobler
PTAL https://codereview.appspot.com/6847107/diff/5002/src/pkg/regexp/example_test.go File src/pkg/regexp/example_test.go (right): https://codereview.appspot.com/6847107/diff/5002/src/pkg/regexp/example_test.go#newcode39 src/pkg/regexp/example_test.go:39: fmt.Println(re.FindString("seafood")) On 2012/11/26 19:17:52, rsc wrote: > fmt.Printf("%q", ...
11 years, 4 months ago (2012-11-26 21:59:38 UTC) #5
rsc
LGTM
11 years, 4 months ago (2012-11-27 15:32:07 UTC) #6
rsc
11 years, 4 months ago (2012-11-27 15:33:19 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=9050012c9765 ***

regexp: add examples

Update issue 4125

R=minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6847107

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b