Issue 6847072: code review 6847072: net/http/cgi: another attempt to fix windows tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847072: code review 6847072: net/http/cgi: another attempt to fix windows tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by brainman

Modified:
11 years, 6 months ago

Reviewers:

CC:
golang-dev, bradfitz, mkrautz

Visibility:
Public.

Description

net/http/cgi: another attempt to fix windows tests Also enables TestDirWindows test on windows. Fixes Issue 4401.

Patch Set 1 #

Patch Set 2 : diff -r a070de932857 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a070de932857 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 14cfbda9e18a https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -57 lines)			Patch
	M	src/pkg/net/http/cgi/host_test.go	View	1	3 chunks	+4 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/cgi/testdata/test.cgi	View	1	3 chunks	+21 lines, -56 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org, krautz@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-11-20 01:42:26 UTC) #1

brainman

11 years, 6 months ago (2012-11-20 05:24:18 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0281f4be1b96 ***

net/http/cgi: another attempt to fix windows tests

Also enables TestDirWindows test on windows.

Fixes Issue 4401.

R=golang-dev, bradfitz
CC=golang-dev, krautz
http://codereview.appspot.com/6847072

Expand All Messages | Collapse All Messages