Issue 6826088: code review 6826088: runtime: allow up to 128 GB of allocated memory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6826088: code review 6826088: runtime: allow up to 128 GB of allocated memory (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rsc

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, iant, dho

Visibility:
Public.

Description

runtime: allow up to 128 GB of allocated memory Incorporates code from CL 6828055. Fixes issue 2142.

Patch Set 2 : diff -r ab868a8f3128 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ab868a8f3128 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 572254dde730 https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
	M	src/pkg/runtime/malloc.h	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/pkg/runtime/malloc.goc	View	1 2 3	1 chunk	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-12 19:52:41 UTC) #1

iant

LGTM https://codereview.appspot.com/6826088/diff/5001/src/pkg/runtime/malloc.h File src/pkg/runtime/malloc.h (right): https://codereview.appspot.com/6826088/diff/5001/src/pkg/runtime/malloc.h#newcode136 src/pkg/runtime/malloc.h:136: #define MaxMem (1ULL<<(MHeapMap_Bits+PageShift)) /* 16 GB */ s/16/128/ ...

11 years, 5 months ago (2012-11-12 20:20:58 UTC) #2

dho

http://codereview.appspot.com/6826088/diff/5001/src/pkg/runtime/malloc.goc File src/pkg/runtime/malloc.goc (right): http://codereview.appspot.com/6826088/diff/5001/src/pkg/runtime/malloc.goc#newcode343 src/pkg/runtime/malloc.goc:343: // Actually we reserve 136 GB (because the bitmap ...

11 years, 5 months ago (2012-11-12 21:56:00 UTC) #3

dho

On 2012/11/12 21:56:00, dho wrote: > http://codereview.appspot.com/6826088/diff/5001/src/pkg/runtime/malloc.goc > File src/pkg/runtime/malloc.goc (right): > > http://codereview.appspot.com/6826088/diff/5001/src/pkg/runtime/malloc.goc#newcode343 > ...

11 years, 5 months ago (2012-11-12 21:56:29 UTC) #4

rsc

11 years, 5 months ago (2012-11-13 17:45:19 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=a310cb32c278 ***

runtime: allow up to 128 GB of allocated memory

Incorporates code from CL 6828055.

Fixes issue 2142.

R=golang-dev, iant, devon.odell
CC=golang-dev
http://codereview.appspot.com/6826088

Expand All Messages | Collapse All Messages