Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14025)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6822045: code review 6822045: net: implement IPv6 support for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by brainman
Modified:
11 years, 5 months ago
Reviewers:
CC:
golang-dev, bradfitz, mikio, zhoumichaely
Visibility:
Public.

Description

net: implement IPv6 support for windows Thank you zhoumichaely for original CL 5175042. Fixes issue 1740. Fixes issue 2315.

Patch Set 1 #

Patch Set 2 : diff -r 8e87cb8dca7d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8e87cb8dca7d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8087f34d11d6 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 5 : diff -r 5bc48b616305 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 6 : diff -r ad0d92901061 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 1369d7bb329d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -8 lines) Patch
M src/pkg/net/dialgoogle_test.go View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/net/fd_unix.go View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/net/fd_windows.go View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/pkg/net/ipsock.go View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/pkg/net/ipsock_plan9.go View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/net/lookup_windows.go View 1 2 chunks +33 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 5 chunks +36 lines, -3 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14
brainman
Hello golang-dev@googlegroups.com (cc: zhoumichaely@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-10-29 05:42:49 UTC) #1
brainman
This CL breaks goapi check. I have introduced windows syscall.RawSockaddrInet6, and now # go run ...
11 years, 5 months ago (2012-10-29 05:46:26 UTC) #2
bradfitz
This is a bug (or missing feature?) in goapi check. It can't handle the cases ...
11 years, 5 months ago (2012-10-29 09:00:19 UTC) #3
bradfitz
On Mon, Oct 29, 2012 at 6:46 AM, <alex.brainman@gmail.com> wrote: > This CL breaks goapi ...
11 years, 5 months ago (2012-10-30 12:13:47 UTC) #4
brainman
On 2012/10/30 12:13:47, bradfitz wrote: > ... > cmd/api is fixed now. Works for me. ...
11 years, 5 months ago (2012-10-31 00:03:16 UTC) #5
brainman
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com, zhoumichaely@gmail.com), Please take another look.
11 years, 5 months ago (2012-10-31 00:03:34 UTC) #6
mikio
https://codereview.appspot.com/6822045/diff/9002/src/pkg/net/dialgoogle_test.go File src/pkg/net/dialgoogle_test.go (right): https://codereview.appspot.com/6822045/diff/9002/src/pkg/net/dialgoogle_test.go#newcode120 src/pkg/net/dialgoogle_test.go:120: t.Logf("skipping; ipv6 is not supported") s/skipping/skipping test/ https://codereview.appspot.com/6822045/diff/9002/src/pkg/net/ipsock.go File ...
11 years, 5 months ago (2012-10-31 12:43:27 UTC) #7
brainman
Hello golang-dev@googlegroups.com, bradfitz@golang.org, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com, zhoumichaely@gmail.com), Please take another look.
11 years, 5 months ago (2012-11-01 04:28:49 UTC) #8
brainman
https://codereview.appspot.com/6822045/diff/9002/src/pkg/net/dialgoogle_test.go File src/pkg/net/dialgoogle_test.go (right): https://codereview.appspot.com/6822045/diff/9002/src/pkg/net/dialgoogle_test.go#newcode120 src/pkg/net/dialgoogle_test.go:120: t.Logf("skipping; ipv6 is not supported") On 2012/10/31 12:43:28, mikio ...
11 years, 5 months ago (2012-11-01 04:28:59 UTC) #9
mikio
pls re-run hg update. https://codereview.appspot.com/6822045/diff/12001/src/pkg/net/fd_unix.go File src/pkg/net/fd_unix.go (right): https://codereview.appspot.com/6822045/diff/12001/src/pkg/net/fd_unix.go#newcode676 src/pkg/net/fd_unix.go:676: func sysInit() { pls move ...
11 years, 5 months ago (2012-11-06 08:56:54 UTC) #10
brainman
https://codereview.appspot.com/6822045/diff/12001/src/pkg/net/fd_unix.go File src/pkg/net/fd_unix.go (right): https://codereview.appspot.com/6822045/diff/12001/src/pkg/net/fd_unix.go#newcode676 src/pkg/net/fd_unix.go:676: func sysInit() { On 2012/11/06 08:56:54, mikio wrote: > ...
11 years, 5 months ago (2012-11-07 00:22:03 UTC) #11
brainman
Hello golang-dev@googlegroups.com, bradfitz@golang.org, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com, zhoumichaely@gmail.com), Please take another look.
11 years, 5 months ago (2012-11-07 00:22:28 UTC) #12
mikio
LGTM
11 years, 5 months ago (2012-11-07 01:05:10 UTC) #13
brainman
11 years, 5 months ago (2012-11-07 05:58:29 UTC) #14 
*** Submitted as http://code.google.com/p/go/source/detail?r=6071da247007 ***

net: implement IPv6 support for windows

Thank you zhoumichaely for original CL 5175042.

Fixes issue 1740.
Fixes issue 2315.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev, zhoumichaely
http://codereview.appspot.com/6822045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b