Issue 6818101: code review 6818101: archive/tar: avoid writing ModTime that is out of range.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6818101: code review 6818101: archive/tar: avoid writing ModTime that is out of range. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dsymonds

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

archive/tar: avoid writing ModTime that is out of range. Update issue 4358 Still to do: support binary numeric format in Reader.

Patch Set 1 #

Patch Set 2 : diff -r ad0d92901061 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ad0d92901061 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ad0d92901061 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r aae11629f3e8 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -13 lines)			Patch
	M	src/pkg/archive/tar/tar_test.go	View	1	2 chunks	+43 lines, -0 lines	0 comments	Download
	M	src/pkg/archive/tar/writer.go	View	1	3 chunks	+26 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-11-07 02:31:18 UTC) #1

dsymonds

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 6 months ago (2012-11-07 02:47:03 UTC) #2

dsymonds

11 years, 5 months ago (2012-11-07 21:22:50 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b4481bc83b6a ***

archive/tar: avoid writing ModTime that is out of range.

Update issue 4358
Still to do: support binary numeric format in Reader.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6818101

Expand All Messages | Collapse All Messages