code review 6818067: unicode: move unicode and related packages to Unicode 6.2.0.

unicode: move unicode and related packages to Unicode 6.2.0.

[mpvl, 2012-10-31 14:58:25]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2012-10-31 15:40:48]

LGTM
although it was never this easy before. did you run make testtables in the
unicode directory?

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/maketables.go
File src/pkg/unicode/maketables.go (right):

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/maketables.go...
src/pkg/unicode/maketables.go:370: if line[0] == '#' || line[0] == '\n' {
ReadString returns the delimiter. blank lines will break the code below.

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/script_test.go
File src/pkg/unicode/script_test.go (right):

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/script_test.g...
src/pkg/unicode/script_test.go:17: // Hand-chosen tests from Unicode 5.1.0 &
6.0..0, mostly to discover when new
update comment.

[mpvl, 2012-10-31 16:26:29]

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/maketables.go
File src/pkg/unicode/maketables.go (right):

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/maketables.go...
src/pkg/unicode/maketables.go:370: if line[0] == '#' || line[0] == '\n' {
This function of this code is exactly to skip blank lines (unlike the 6.0.0
files, the 6.2.0 files have blank lines). So not sure what the issue is.
Replaced with something more robust, though.

On 2012/10/31 15:40:48, r wrote:
> ReadString returns the delimiter. blank lines will break the code below.

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/script_test.go
File src/pkg/unicode/script_test.go (right):

http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/script_test.g...
src/pkg/unicode/script_test.go:17: // Hand-chosen tests from Unicode 5.1.0 &
6.0..0, mostly to discover when new
On 2012/10/31 15:40:48, r wrote:
> update comment.

Done.

[mpvl_google.com, 2012-10-31 16:27:12]

It does seem too good to be true, but I guess the Unicode standard is
stabilizing a bit.

For the record, the following all pass:
unicode:
- go test
- make testtables

exp/norm:
- go test
- make testtables
- make regtest

exp/locale/collate:
- go test
- go run regtest.go

exp/locale/collate/build:
- go test

As well as using colcmp to regress the new build against icu50 (which uses
Unicode 6.2.0 and CLDR 22) for all locales that previously worked.

Marcel

On Wed, Oct 31, 2012 at 4:40 PM, <r@golang.org> wrote:

> LGTM
> although it was never this easy before. did you run make testtables in
> the unicode directory?
>
>
>
> http://codereview.appspot.com/**6818067/diff/2001/src/pkg/**
>
unicode/maketables.go<http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/maketables.go>
> File src/pkg/unicode/maketables.go (right):
>
> http://codereview.appspot.com/**6818067/diff/2001/src/pkg/**
>
unicode/maketables.go#**newcode370<http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/maketables.go#newcode370>
> src/pkg/unicode/maketables.go:**370: if line[0] == '#' || line[0] == '\n'
> {
> ReadString returns the delimiter. blank lines will break the code below.
>
> http://codereview.appspot.com/**6818067/diff/2001/src/pkg/**
>
unicode/script_test.go<http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/script_test.go>
> File src/pkg/unicode/script_test.go (right):
>
> http://codereview.appspot.com/**6818067/diff/2001/src/pkg/**
>
unicode/script_test.go#**newcode17<http://codereview.appspot.com/6818067/diff/2001/src/pkg/unicode/script_test.go#newcode17>
> src/pkg/unicode/script_test.**go:17: // Hand-chosen tests from Unicode
> 5.1.0 & 6.0..0, mostly to discover when new
> update comment.
>
>
http://codereview.appspot.com/**6818067/<http://codereview.appspot.com/6818067/>
>



-- 
Trying this for a while: http://go/OnlyCheckEmailTwiceADay.
Marcel van Lohuizen -- Google Switzerland GmbH -- Identifikationsnummer:
CH-020.4.028.116-1

[mpvl, 2012-10-31 16:32:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=a8ed5d22b36e ***

unicode: move unicode and related packages to Unicode 6.2.0.

R=r, mpvl
CC=golang-dev
http://codereview.appspot.com/6818067

[r, 2012-10-31 17:02:42]

all.bash fails because strconv's tables are out of date. easy to fix, though.

-rob

[mpvl_google.com, 2012-10-31 21:49:32]

I have a CL, but my hg is currently failing to connect to the server.  Will
keep trying.

On Wed, Oct 31, 2012 at 6:02 PM, Rob Pike <r@golang.org> wrote:

> all.bash fails because strconv's tables are out of date. easy to fix,
> though.
>
> -rob
>



-- 
Trying this for a while: http://go/OnlyCheckEmailTwiceADay.
Marcel van Lohuizen -- Google Switzerland GmbH -- Identifikationsnummer:
CH-020.4.028.116-1

[r, 2012-10-31 21:53:54]

it's all fixed.

-rob

[mpvl_google.com, 2012-10-31 22:00:14]

Great.  Just noticed that ./all.bash in my install doesn't seem to run the
tests.  Need to look in to that.

Thanks,

Marcel

On Wed, Oct 31, 2012 at 10:53 PM, Rob Pike <r@golang.org> wrote:

> it's all fixed.
>
> -rob
>



-- 
Trying this for a while: http://go/OnlyCheckEmailTwiceADay.
Marcel van Lohuizen -- Google Switzerland GmbH -- Identifikationsnummer:
CH-020.4.028.116-1