Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 6639051: code review 6639051: cmd/go: Dedup package arguments before building. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by DMorsing
Modified:
11 years, 7 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, minux1
Visibility:
Public.

Description

cmd/go: Dedup package arguments before building. Fixes issue 4104.

Patch Set 1 #

Patch Set 2 : diff -r 06308c9edb43 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 06308c9edb43 https://code.google.com/p/go/ #

Patch Set 4 : diff -r fc8137c00f9c https://code.google.com/p/go/ #

Patch Set 5 : diff -r fc8137c00f9c https://code.google.com/p/go/ #

Patch Set 6 : diff -r 32c1ce44286f https://code.google.com/p/go/ #

Patch Set 7 : diff -r 95b8a6011b40 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/cmd/go/pkg.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/go/test.bash View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
DMorsing
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2012-10-09 19:46:13 UTC) #1
dave_cheney.net
On 2012/10/09 19:46:13, DMorsing wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
11 years, 7 months ago (2012-10-09 23:48:22 UTC) #2
DMorsing
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 7 months ago (2012-10-14 11:21:12 UTC) #3
minux1
LGTM.
11 years, 7 months ago (2012-10-17 07:41:26 UTC) #4
DMorsing
11 years, 7 months ago (2012-10-17 15:23:51 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=bb1308d3d6e6 ***

cmd/go: Dedup package arguments before building.

Fixes issue 4104.

R=golang-dev, dave, minux.ma
CC=golang-dev
http://codereview.appspot.com/6639051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b