Issue 6569050: code review 6569050: syscall: do not use int to test network syscall results...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6569050: code review 6569050: syscall: do not use int to test network syscall results... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by brainman

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

syscall: do not use int to test network syscall results (on windows) Fixes issue 4147.

Patch Set 1 #

Patch Set 2 : diff -r d4627113a3e9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d4627113a3e9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3171c53e9b04 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -162 lines)			Patch
M	src/pkg/syscall/mksyscall_windows.pl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1	1 chunk	+17 lines, -15 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View	1	73 chunks	+73 lines, -73 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_amd64.go	View	1	73 chunks	+73 lines, -73 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2012-09-25 06:59:19 UTC) #1

brainman

11 years, 7 months ago (2012-09-25 07:06:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cfbcf8176d26 ***

syscall: do not use int to test network syscall results (on windows)

Fixes issue 4147.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6569050

Expand All Messages | Collapse All Messages