Issue 6446063: code review 6446063: net/http: don't modify Request Method's case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446063: code review 6446063: net/http: don't modify Request Method's case (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc, dsymonds

Visibility:
Public.

Description

net/http: don't modify Request Method's case This fixes a data race (usually just harmlessly updating "GET" to "GET"), but also follows RFC 2616 Sec 5.1.1 which says that the request method is case-sensitive. Fixes issue 3881

Patch Set 1 #

Patch Set 2 : diff -r 9bf2225c38eb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9bf2225c38eb https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d191515c80fb https://go.googlecode.com/hg/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	src/pkg/net/http/response.go	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download
	M	src/pkg/net/http/serve_test.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2012-07-29 23:58:14 UTC) #1

dsymonds

LGTM I guess this could technically break someone's code, but I don't think it matters.

11 years, 9 months ago (2012-07-30 00:01:17 UTC) #3

bradfitz

11 years, 9 months ago (2012-07-30 00:05:35 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=4aeff61b5401 ***

net/http: don't modify Request Method's case

This fixes a data race (usually just harmlessly updating
"GET" to "GET"), but also follows RFC 2616 Sec 5.1.1 which
says that the request method is case-sensitive.

Fixes issue 3881

R=golang-dev, rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/6446063

Expand All Messages | Collapse All Messages