Issue 6357064: code review 6357064: cmd/go: remove $WORK paths in generated binaries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6357064: code review 6357064: cmd/go: remove $WORK paths in generated binaries (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by minux1

Modified:
11 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: remove $WORK paths in generated binaries Fixes issue 3748.

Patch Set 1 #

Patch Set 2 : diff -r be7e338a8960 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6e5762cf9a29 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6e5762cf9a29 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1f62df249175 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 1f62df249175 https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/go/build.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2012-07-04 04:00:45 UTC) #1

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 10 months ago (2012-07-04 04:02:23 UTC) #2

minux1

11 years, 9 months ago (2012-08-07 02:01:24 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c1ce95068533 ***

cmd/go: remove $WORK paths in generated binaries
        Fixes issue 3748.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6357064

Expand All Messages | Collapse All Messages